Skip to content

Add new cruise icons#377

Merged
jordanjones243 merged 1 commit into
masterfrom
jjones/cruiseIcons/AB#1458948
Jul 24, 2026
Merged

Add new cruise icons#377
jordanjones243 merged 1 commit into
masterfrom
jjones/cruiseIcons/AB#1458948

Conversation

@jordanjones243

@jordanjones243 jordanjones243 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: https://itsals.visualstudio.com/E_Retain_Content/_workitems/edit/1458948

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Rendered Icons

image

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

New Features:

  • Introduce new cruise-stroke and cruise-filled SVG icons for use in the design system.

@jordanjones243 jordanjones243 self-assigned this Jul 23, 2026
@jordanjones243
jordanjones243 requested a review from a team as a code owner July 23, 2026 23:05
@sourcery-ai

sourcery-ai Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds new cruise-themed icons to the design system and wires them into the icon metadata so they can be consumed like existing icons.

File-Level Changes

Change Details Files
Register new cruise icons in the icon metadata so they are available to consumers.
  • Update the icon data configuration to include entries for the new cruise icons (likely stroke and filled variants).
  • Ensure the new icons follow existing naming and categorization conventions used in the icon registry.
 src/data/icons.json
Introduce new SVG assets for cruise icons in stroke and filled styles.
  • Add a stroke-style cruise SVG asset matching existing icon sizing and stroke conventions.
  • Add a filled-style cruise SVG asset matching existing icon sizing and fill conventions.
 src/icons/ cruise-stroke.svg
src/icons/cruise-filled.svg
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 23, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • There appears to be a leading space in the new file path src/icons/ cruise-stroke.svg; please confirm the actual filename doesn’t include this space and is consistent with the rest of the icon set.
  • Double-check that the new cruise-stroke and cruise-filled icon names and variants are aligned with the existing naming conventions and structure used in icons.json (e.g., key names, style variants, and ordering).
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- There appears to be a leading space in the new file path `src/icons/ cruise-stroke.svg`; please confirm the actual filename doesn’t include this space and is consistent with the rest of the icon set.
- Double-check that the new `cruise-stroke` and `cruise-filled` icon names and variants are aligned with the existing naming conventions and structure used in `icons.json` (e.g., key names, style variants, and ordering).
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

jason-capsule42
jason-capsule42 requested changes Jul 23, 2026
View reviewed changes
Comment thread src/icons/cruise-filled.svg
devhowyalike
devhowyalike previously requested changes Jul 23, 2026
View reviewed changes

@devhowyalike devhowyalike left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice crusie-stroke.svg has this:

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">

But cruise-fileld.svg has just this:

<svg>

@jason-capsule42

jason-capsule42 commented Jul 23, 2026

Copy link
Copy Markdown
Member

I notice crusie-stroke.svg has this:

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">

But cruise-fileld.svg has just this:

<svg>

This is probably why the GitHub PR shows them as different sizes when looking at the changes.

@jordanjones243
jordanjones243 force-pushed the jjones/cruiseIcons/AB#1458948 branch from b7b2f52 to 05d2fd9 Compare July 24, 2026 00:05
@jordanjones243
jordanjones243 force-pushed the jjones/cruiseIcons/AB#1458948 branch from 05d2fd9 to 3619fa2 Compare July 24, 2026 16:47
chrisfalaska
chrisfalaska approved these changes Jul 24, 2026
View reviewed changes

@chrisfalaska chrisfalaska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and verified locally

@jordanjones243 jordanjones243 linked an issue Jul 24, 2026 that may be closed by this pull request
New Cruise Filled Icon & Updated Cruise-Stroke Icon #300
Closed
@jordanjones243
jordanjones243 merged commit 4129c4c into master Jul 24, 2026
3 checks passed
@jordanjones243
jordanjones243 deleted the jjones/cruiseIcons/AB#1458948 branch July 24, 2026 16:58
@blackfalcon

blackfalcon commented Jul 24, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@jason-capsule42 jason-capsule42 jason-capsule42 approved these changes
@chrisfalaska chrisfalaska chrisfalaska approved these changes
+1 more reviewer
@devhowyalike devhowyalike devhowyalike left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jordanjones243 jordanjones243

Labels

released Completed work has been released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Cruise Filled Icon & Updated Cruise-Stroke Icon

5 participants

@jordanjones243 @jason-capsule42 @blackfalcon @devhowyalike @chrisfalaska